allow to increase total count on most progress bars, fixes incorrect output in load stage #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
commented
Nov 27, 2024
| @@ -333,19 +383,28 @@ def update( | |||
| bar = alive_bar(total=total, title=desc, **self.alive_kwargs) | |||
| self._bars_contexts[key] = bar | |||
| bar = self._bars[key] = bar.__enter__() | |||
| self._bars_counts[key] = 0 | |||
| else: | |||
| # TODO: implement once total change is supported | |||
There was a problem hiding this comment.
alive bars don't seem to support updating the total, you can create a new one and remember the old settings, but then a new bar appears in the ui, and the old half files one stays..
There was a problem hiding this comment.
alive is just for fun. so OK :)
rudolfix
approved these changes
Nov 27, 2024
| @@ -333,19 +383,28 @@ def update( | |||
| bar = alive_bar(total=total, title=desc, **self.alive_kwargs) | |||
| self._bars_contexts[key] = bar | |||
| bar = self._bars[key] = bar.__enter__() | |||
| self._bars_counts[key] = 0 | |||
| else: | |||
| # TODO: implement once total change is supported | |||
There was a problem hiding this comment.
alive is just for fun. so OK :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for increasing total on progress bars.